• Skip to main content
  • Skip to header right navigation
  • Skip to site footer

My Online Training Hub

Learn Dashboards, Excel, Power BI, Power Query, Power Pivot

  • Courses
  • Pricing
    • Free Courses
    • Power BI Course
    • Excel Power Query Course
    • Power Pivot and DAX Course
    • Excel Dashboard Course
    • Excel PivotTable Course – Quick Start
    • Advanced Excel Formulas Course
    • Excel Expert Advanced Excel Training
    • Excel Tables Course
    • Excel, Word, Outlook
    • Financial Modelling Course
    • Excel PivotTable Course
    • Excel for Customer Service Professionals
    • Excel for Operations Management Course
    • Excel for Decision Making Under Uncertainty Course
    • Excel for Finance Course
    • Excel Analysis ToolPak Course
    • Multi-User Pricing
  • Resources
    • Free Downloads
    • Excel Functions Explained
    • Excel Formulas
    • Excel Add-ins
    • IF Function
      • Excel IF Statement Explained
      • Excel IF AND OR Functions
      • IF Formula Builder
    • Time & Dates in Excel
      • Excel Date & Time
      • Calculating Time in Excel
      • Excel Time Calculation Tricks
      • Excel Date and Time Formatting
    • Excel Keyboard Shortcuts
    • Excel Custom Number Format Guide
    • Pivot Tables Guide
    • VLOOKUP Guide
    • ALT Codes
    • Excel VBA & Macros
    • Excel User Forms
    • VBA String Functions
  • Members
    • Login
    • Password Reset
  • Blog
  • Excel Webinars
  • Excel Forum
    • Register as Forum Member

Search code not working all the time|VBA & Macros|Excel Forum|My Online Training Hub

You are here: Home / Search code not working all the time|VBA & Macros|Excel Forum|My Online Training Hub
Avatar
sp_LogInOut Log In sp_Registration Register
sp_Search Search
Advanced Search|Last Search Results
Search
Forum Scope




Match



Forum Options



Minimum search word length is 3 characters - maximum search word length is 84 characters
sp_Search Search
sp_RankInfo
Lost password?
sp_CrumbsHome HomeExcel ForumVBA & MacrosSearch code not working all the tim…
sp_PrintTopic sp_TopicIcon
Search code not working all the time
Avatar
Jose Zavala
Member
Members
Level 0
Forum Posts: 41
Member Since:
October 25, 2017
sp_UserOfflineSmall Offline
1
March 3, 2022 - 6:39 am
sp_Permalink sp_Print

Hi,

I have this code for searching but not working when I type in SAGEID textbox for example 100261 get message data not found but I know the number is there is there something wrong with code: (attaching sample file)

 

Private Sub CommandButton1_Click()
Dim wsDistCode As Worksheet
Dim m As Variant, Search As Variant
Dim i As Long, C As Long

Set wsDistCode = ThisWorkbook.Worksheets("DIST_CODE")

For C = 1 To 8
Search = Me.Controls("TextBox" & C)
If Len(Search) > 0 Then
If IsNumeric(Search) Then Search = Val(Search)
m = Application.Match(Search, wsDistCode.Columns(C), 0)
For i = 1 To 8
Me.Controls("TextBox" & i).Value = IIf(Not IsError(m), wsDistCode.Cells(CLng(m), i).Text, "")
Next i
Exit For
End If
Next

If IsError(m) Then MsgBox Search & Chr(10) & " DATA Not FOUND", 48, "Not Found"

End Sub

sp_AnswersTopicSeeAnswer See Answer
Avatar
Velouria
London or thereabouts
Moderator
Members


Trusted Members

Moderators
Level 4
Forum Posts: 617
Member Since:
November 1, 2018
sp_UserOfflineSmall Offline
2
March 3, 2022 - 7:48 pm
sp_Permalink sp_Print

There's no file attached but, in the meantime, if your codes are stored as text in the worksheet, then that code won't find them because it converts all numeric strings to actual numbers. Try commenting out this line:

If IsNumeric(Search) Then Search = Val(Search)

 

If that fixes it, then that was the problem.

Avatar
Jose Zavala
Member
Members
Level 0
Forum Posts: 41
Member Since:
October 25, 2017
sp_UserOfflineSmall Offline
3
March 4, 2022 - 3:07 am
sp_Permalink sp_Print

Hi,

Yes, SAGEID is like vendor number but sometimes works for example if type first time doesn't but If I go to spreadsheet and retype the number and try agian works, the the wildcard search for vendor name works is just SAGEID doesn't work all the time.

I commented out that line seems to work, just attaching the file now if you can please check if that really the problem, much appreciated.

 

 

Thank you,

Avatar
Velouria
London or thereabouts
Moderator
Members


Trusted Members

Moderators
Level 4
Forum Posts: 617
Member Since:
November 1, 2018
sp_UserOfflineSmall Offline
4
March 4, 2022 - 7:15 pm
sp_Permalink sp_Print

Yes, that is the issue. I assume you have done exactly that in the sample workbook because now you have a mix of actual numbers and numbers stored as text, which could cause you issues. You also appear to have the same ID repeated more than once, and your search code will only ever find the first entry.

 

As a general comment, you have a fair amount of repeated code which could really do with refactoring into separate routines - it will make maintenance easier.

sp_AnswersTopicAnswer
Answers Post
Avatar
Jose Zavala
Member
Members
Level 0
Forum Posts: 41
Member Since:
October 25, 2017
sp_UserOfflineSmall Offline
5
March 5, 2022 - 2:24 am
sp_Permalink sp_Print

Thank you.

sp_Feed
Go to top
Forum Timezone: Australia/Brisbane
Most Users Ever Online: 245
Currently Online: Lynnette Altomari, Roy Lutke, Jeff Krueger, Natasha Smith, Monique Roussouw
Guest(s) 12
Currently Browsing this Page:
1 Guest(s)
Top Posters:
SunnyKow: 1432
Anders Sehlstedt: 870
Purfleet: 412
Frans Visser: 346
David_Ng: 306
lea cohen: 219
A.Maurizio: 202
Jessica Stewart: 202
Aye Mu: 201
jaryszek: 183
Newest Members:
Sopi Yuniarti
sandra parker
LAFONSO HERNANDEZ
Hayden Hao
Angela chen
Sean Moore
John Chisholm
vexokeb sdfg
John Jack
Malcolm Toy
Forum Stats:
Groups: 3
Forums: 24
Topics: 6214
Posts: 27243

 

Member Stats:
Guest Posters: 49
Members: 31894
Moderators: 3
Admins: 4
Administrators: Mynda Treacy, Philip Treacy, Catalin Bombea, FT
Moderators: MOTH Support, Velouria, Riny van Eekelen
© Simple:Press —sp_Information

Sidebar

Blog Categories

  • Excel
  • Excel Charts
  • Excel Dashboard
  • Excel Formulas
  • Excel PivotTables
  • Excel Shortcuts
  • Excel VBA
  • General Tips
  • Online Training
  • Outlook
  • Power Apps
  • Power Automate
  • Power BI
  • Power Pivot
  • Power Query
microsoft mvp logo
trustpilot excellent rating
Secured by Sucuri Badge
MyOnlineTrainingHub on YouTube Mynda Treacy on Linked In Mynda Treacy on Instagram Mynda Treacy on Twitter Mynda Treacy on Pinterest MyOnlineTrainingHub on Facebook
 

Company

  • About My Online Training Hub
  • Disclosure Statement
  • Frequently Asked Questions
  • Guarantee
  • Privacy Policy
  • Terms & Conditions
  • Testimonials
  • Become an Affiliate

Support

  • Contact
  • Forum
  • Helpdesk - For Technical Issues

Copyright © 2023 · My Online Training Hub · All Rights Reserved. Microsoft and the Microsoft Office logo are trademarks or registered trademarks of Microsoft Corporation in the United States and/or other countries. Product names, logos, brands, and other trademarks featured or referred to within this website are the property of their respective trademark holders.