• Skip to main content
  • Skip to header right navigation
  • Skip to site footer

My Online Training Hub

Learn Dashboards, Excel, Power BI, Power Query, Power Pivot

  • Courses
  • Pricing
    • Free Courses
    • Power BI Course
    • Excel Power Query Course
    • Power Pivot and DAX Course
    • Excel Dashboard Course
    • Excel PivotTable Course – Quick Start
    • Advanced Excel Formulas Course
    • Excel Expert Advanced Excel Training
    • Excel Tables Course
    • Excel, Word, Outlook
    • Financial Modelling Course
    • Excel PivotTable Course
    • Excel for Customer Service Professionals
    • Excel for Operations Management Course
    • Excel for Decision Making Under Uncertainty Course
    • Excel for Finance Course
    • Excel Analysis ToolPak Course
    • Multi-User Pricing
  • Resources
    • Free Downloads
    • Excel Functions Explained
    • Excel Formulas
    • Excel Add-ins
    • IF Function
      • Excel IF Statement Explained
      • Excel IF AND OR Functions
      • IF Formula Builder
    • Time & Dates in Excel
      • Excel Date & Time
      • Calculating Time in Excel
      • Excel Time Calculation Tricks
      • Excel Date and Time Formatting
    • Excel Keyboard Shortcuts
    • Excel Custom Number Format Guide
    • Pivot Tables Guide
    • VLOOKUP Guide
    • ALT Codes
    • Excel VBA & Macros
    • Excel User Forms
    • VBA String Functions
  • Members
    • Login
    • Password Reset
  • Blog
  • Excel Webinars
  • Excel Forum
    • Register as Forum Member

How to merge two subs with Private Sub Worksheet_Change on sheet|VBA & Macros|Excel Forum|My Online Training Hub

You are here: Home / How to merge two subs with Private Sub Worksheet_Change on sheet|VBA & Macros|Excel Forum|My Online Training Hub
Avatar
sp_LogInOut Log In sp_Registration Register
sp_Search Search
Advanced Search|Last Search Results
Search
Forum Scope




Match



Forum Options



Minimum search word length is 3 characters - maximum search word length is 84 characters
sp_Search Search
sp_RankInfo
Lost password?
sp_CrumbsHome HomeExcel ForumVBA & MacrosHow to merge two subs with Private …
sp_PrintTopic sp_TopicIcon
How to merge two subs with Private Sub Worksheet_Change on sheet
Avatar
GIANNIS DIMO

Active Member
Members
Level 0
Forum Posts: 4
Member Since:
March 5, 2018
sp_UserOfflineSmall Offline
1
April 18, 2019 - 12:51 am
sp_Permalink sp_Print

Hello,

I need to combine two Private Sub Worksheet_Change(ByVal Target As Range) I'm new to Excel VBA code, how can I do this? Code below.

1)

Option Explicit Const strAFM As String = "D3:D1000" Private Sub Worksheet_Change(ByVal Target As Range) Dim Rng As Range, AFM As String, rngTomi As Range Set Rng = Range(strAFM) Set rngTomi = Intersect(Target, Rng) If rngTomi Is Nothing Then Exit Sub If rngTomi.Count <> 1 Then rngTomi.ClearContents Exit Sub End If If Trim(Target.Value) = "" Then Exit Sub AFM = Right("000000000" & Target.Value, 9) If isAFM(AFM) = False Then MsgBox "no afm" Target.Activate Exit Sub End If End Sub

2)

Private Sub Worksheet_Change(ByVal Target As Range) If Target.Count > 1 Then Exit Sub Dim Rng As Range Set Rng = Me.Range("ColTarget") If Intersect(Target, Rng) Is Nothing Then Exit Sub ResizeTbl End Sub

Avatar
Philip Treacy
Admin
Level 10
Forum Posts: 1510
Member Since:
October 5, 2010
sp_UserOfflineSmall Offline
2
April 18, 2019 - 9:55 am
sp_Permalink sp_Print

Hi Giannis,

It depends on what you want the combined Subs to do.

For example, you have If Target.Count > 1 Then Exit Sub in one Sub, do you want this in the combined Sub?

You have two similar statements

Set Rng = Range(strAFM)

Set Rng = Me.Range("ColTarget")

which one do you want to use?

Do you want to call ResizeTbl in the combined sub?  If so, at what point?

Without clear direction of what you want to do I don't know how to combine the code.  Not knowing what ResizeTbl and isAFM do, also makes it tricky.

If you want to provide code, please attach your workbook to the forum post.

Regards

Phil

Avatar
GIANNIS DIMO

Active Member
Members
Level 0
Forum Posts: 4
Member Since:
March 5, 2018
sp_UserOfflineSmall Offline
3
April 18, 2019 - 9:51 pm
sp_Permalink sp_Print

Hello,
Thanks for the answer, finally found a solution as below and works

 

Option Explicit Const strAFM As String = "D3:D1000" Private Sub Worksheet_Change(ByVal Target As Range) Dim Rng As Range, AFM As String, rngTomi As Range If Not Target.Count > 1 Then Set Rng = Me.Range("ColTarget") If Not Intersect(Target, Rng) Is Nothing Then ResizeTbl End If Set Rng = Range(strAFM) Set rngTomi = Intersect(Target, Rng) If Not rngTomi Is Nothing Then If rngTomi.Count <> 1 Then Application.EnableEvents = False rngTomi.ClearContents Application.EnableEvents = False Exit Sub End If If Trim(Target.Value) = "" Then Exit Sub AFM = Right("000000000" & Target.Value, 9) If isAFM(AFM) = False Then MsgBox "no afm" Target.Activate Exit Sub End If End If End Sub

sp_Feed
Go to top
Forum Timezone: Australia/Brisbane
Most Users Ever Online: 245
Currently Online: Dieneba NDIAYE, Ben Hughes, Jay Soysa, Marco Marques, Christopher Anderson, Natasha Smith
Guest(s) 9
Currently Browsing this Page:
1 Guest(s)
Top Posters:
SunnyKow: 1432
Anders Sehlstedt: 870
Purfleet: 412
Frans Visser: 346
David_Ng: 306
lea cohen: 219
A.Maurizio: 202
Jessica Stewart: 202
Aye Mu: 201
jaryszek: 183
Newest Members:
dectator mang
Francis Drouillard
Orlando Inocente
Jovitha Clemence
Maloxat Axmatovna
Ricardo Freitas
Marko Meglic
Kelly smith
Alan Rushton
Zack Nilsson
Forum Stats:
Groups: 3
Forums: 24
Topics: 6200
Posts: 27181

 

Member Stats:
Guest Posters: 49
Members: 31858
Moderators: 3
Admins: 4
Administrators: Mynda Treacy, Philip Treacy, Catalin Bombea, FT
Moderators: MOTH Support, Velouria, Riny van Eekelen
© Simple:Press —sp_Information

Sidebar

Blog Categories

  • Excel
  • Excel Charts
  • Excel Dashboard
  • Excel Formulas
  • Excel PivotTables
  • Excel Shortcuts
  • Excel VBA
  • General Tips
  • Online Training
  • Outlook
  • Power Apps
  • Power Automate
  • Power BI
  • Power Pivot
  • Power Query
microsoft mvp logo
trustpilot excellent rating
Secured by Sucuri Badge
MyOnlineTrainingHub on YouTube Mynda Treacy on Linked In Mynda Treacy on Instagram Mynda Treacy on Twitter Mynda Treacy on Pinterest MyOnlineTrainingHub on Facebook
 

Company

  • About My Online Training Hub
  • Disclosure Statement
  • Frequently Asked Questions
  • Guarantee
  • Privacy Policy
  • Terms & Conditions
  • Testimonials
  • Become an Affiliate

Support

  • Contact
  • Forum
  • Helpdesk - For Technical Issues

Copyright © 2023 · My Online Training Hub · All Rights Reserved. Microsoft and the Microsoft Office logo are trademarks or registered trademarks of Microsoft Corporation in the United States and/or other countries. Product names, logos, brands, and other trademarks featured or referred to within this website are the property of their respective trademark holders.