• Skip to main content
  • Skip to header right navigation
  • Skip to site footer

My Online Training Hub

Learn Dashboards, Excel, Power BI, Power Query, Power Pivot

  • Courses
  • Pricing
    • Free Courses
    • Power BI Course
    • Excel Power Query Course
    • Power Pivot and DAX Course
    • Excel Dashboard Course
    • Excel PivotTable Course – Quick Start
    • Advanced Excel Formulas Course
    • Excel Expert Advanced Excel Training
    • Excel Tables Course
    • Excel, Word, Outlook
    • Financial Modelling Course
    • Excel PivotTable Course
    • Excel for Customer Service Professionals
    • Excel for Operations Management Course
    • Excel for Decision Making Under Uncertainty Course
    • Excel for Finance Course
    • Excel Analysis ToolPak Course
    • Multi-User Pricing
  • Resources
    • Free Downloads
    • Excel Functions Explained
    • Excel Formulas
    • Excel Add-ins
    • IF Function
      • Excel IF Statement Explained
      • Excel IF AND OR Functions
      • IF Formula Builder
    • Time & Dates in Excel
      • Excel Date & Time
      • Calculating Time in Excel
      • Excel Time Calculation Tricks
      • Excel Date and Time Formatting
    • Excel Keyboard Shortcuts
    • Excel Custom Number Format Guide
    • Pivot Tables Guide
    • VLOOKUP Guide
    • ALT Codes
    • Excel VBA & Macros
    • Excel User Forms
    • VBA String Functions
  • Members
    • Login
    • Password Reset
  • Blog
  • Excel Webinars
  • Excel Forum
    • Register as Forum Member

VBA: Format command not looping through worksheets|VBA & Macros|Excel Forum|My Online Training Hub

You are here: Home / VBA: Format command not looping through worksheets|VBA & Macros|Excel Forum|My Online Training Hub
Avatar
sp_LogInOut Log In sp_Registration Register
sp_Search Search
Advanced Search|Last Search Results
Search
Forum Scope




Match



Forum Options



Minimum search word length is 3 characters - maximum search word length is 84 characters
sp_Search Search
sp_RankInfo
Lost password?
sp_CrumbsHome HomeExcel ForumVBA & MacrosVBA: Format command not looping thr…
sp_PrintTopic sp_TopicIcon
VBA: Format command not looping through worksheets
Avatar
Georgia W

New Member
Members
Level 0
Forum Posts: 1
Member Since:
November 21, 2020
sp_UserOfflineSmall Offline
1
November 21, 2020 - 4:31 am
sp_Permalink sp_Print

Hi all, I am new to VBA so sorry if this is obvious.

I have a macro which copies sheets from a Masterfile into a Template output file containing formatting.

Because the output can have varying column numbers I have written a command which clears formatting from whenever the data finishes.

The second demand then clears contents of column A (which contains lookup references, hence isn't wanted for the output).

 

These commands work as when I run the macro the first sheet is formatted correctly.

However, it doesn't loop the formatting commands through to the other worksheets.

My code reads as below.

' Clear formatting for all columns after last column
' Clear contents of Column A

Dim ws As Worksheet
For Each ws In Worksheets

Set LastCell = Cells.Find(What:="*", After:=Cells(1, 1), LookIn:=xlFormulas, LookAt:= _
xlPart, SearchOrder:=xlByColumns, SearchDirection:=xlPrevious, MatchCase:=False)
LastColumn = LastCell.Column

Range(Columns(LastColumn + 1), Columns(Columns.Count)).ClearFormats
Columns(1).ClearContents

Next

Any help at all would be appreciated!

Avatar
Purfleet
England
Member
Members


Trusted Members
Level 4
Forum Posts: 412
Member Since:
December 20, 2019
sp_UserOfflineSmall Offline
2
November 21, 2020 - 2:59 pm
sp_Permalink sp_Print

Please add worksheet examples, it means we don’t have to waste time creating data that you already have and it ensures it is in the correct format.

the issue you have is that you are not telling the code to move to the next worksheet

The for each ws in worksheets is looping through the sheets, but in excel you are still looking at Sheet1 and all the code after this is acting on the active worksheet.

So you need to either 'fully qualify' where you want the action to occur at each action (this is normally considered best practice as you know exactly where something is happening)

Sub Moth()

' Clear formatting for all columns after last column
' Clear contents of Column A

Dim ws As Worksheet
For Each ws In Worksheets

Set LastCell = ws.Cells.Find(What:="*", After:=Cells(1, 1), LookIn:=xlFormulas, LookAt:= _
xlPart, SearchOrder:=xlByColumns, SearchDirection:=xlPrevious, MatchCase:=False)
LastColumn = LastCell.Column

ws.Range(ws.Columns(LastColumn + 1), ws.Columns(ws.Columns.Count)).ClearFormats
ws.Columns(1).ClearContents

Next

End Sub

Or you tell Excel to move sheets, so the action is happening on the active sheet - this can slow down the process but its unlikely to have any impact on small datasets. Just add in the ws.activate line below. (this is a bit easier bit if you select a different sheet you can sometimes get things happening in the wrong place)

Dim ws As Worksheet
For Each ws In Worksheets

ws.Activate

Set LastCell = Cells.Find(What:="*", After:=Cells(1, 1), LookIn:=xlFormulas, LookAt:= _
xlPart, SearchOrder:=xlByColumns, SearchDirection:=xlPrevious, MatchCase:=False)
LastColumn = LastCell.Column

Range(Columns(LastColumn + 1), Columns(Columns.Count)).ClearFormats
Columns(1).ClearContents

Next

End Sub

sp_Feed
Go to top
Forum Timezone: Australia/Brisbane
Most Users Ever Online: 245
Currently Online: Philip Treacy, Moshe Arama
Guest(s) 10
Currently Browsing this Page:
1 Guest(s)
Top Posters:
SunnyKow: 1432
Anders Sehlstedt: 870
Purfleet: 412
Frans Visser: 346
David_Ng: 306
lea cohen: 219
A.Maurizio: 202
Jessica Stewart: 202
Aye Mu: 201
jaryszek: 183
Newest Members:
yashal minahil
Oluwadamilola Ogun
Yannik H
dectator mang
Francis Drouillard
Orlando Inocente
Jovitha Clemence
Maloxat Axmatovna
Ricardo Freitas
Marko Meglic
Forum Stats:
Groups: 3
Forums: 24
Topics: 6200
Posts: 27183

 

Member Stats:
Guest Posters: 49
Members: 31861
Moderators: 3
Admins: 4
Administrators: Mynda Treacy, Philip Treacy, Catalin Bombea, FT
Moderators: MOTH Support, Velouria, Riny van Eekelen
© Simple:Press —sp_Information

Sidebar

Blog Categories

  • Excel
  • Excel Charts
  • Excel Dashboard
  • Excel Formulas
  • Excel PivotTables
  • Excel Shortcuts
  • Excel VBA
  • General Tips
  • Online Training
  • Outlook
  • Power Apps
  • Power Automate
  • Power BI
  • Power Pivot
  • Power Query
microsoft mvp logo
trustpilot excellent rating
Secured by Sucuri Badge
MyOnlineTrainingHub on YouTube Mynda Treacy on Linked In Mynda Treacy on Instagram Mynda Treacy on Twitter Mynda Treacy on Pinterest MyOnlineTrainingHub on Facebook
 

Company

  • About My Online Training Hub
  • Disclosure Statement
  • Frequently Asked Questions
  • Guarantee
  • Privacy Policy
  • Terms & Conditions
  • Testimonials
  • Become an Affiliate

Support

  • Contact
  • Forum
  • Helpdesk - For Technical Issues

Copyright © 2023 · My Online Training Hub · All Rights Reserved. Microsoft and the Microsoft Office logo are trademarks or registered trademarks of Microsoft Corporation in the United States and/or other countries. Product names, logos, brands, and other trademarks featured or referred to within this website are the property of their respective trademark holders.