• Skip to main content
  • Skip to header right navigation
  • Skip to site footer

My Online Training Hub

Learn Dashboards, Excel, Power BI, Power Query, Power Pivot

  • Courses
  • Pricing
    • Free Courses
    • Power BI Course
    • Excel Power Query Course
    • Power Pivot and DAX Course
    • Excel Dashboard Course
    • Excel PivotTable Course – Quick Start
    • Advanced Excel Formulas Course
    • Excel Expert Advanced Excel Training
    • Excel Tables Course
    • Excel, Word, Outlook
    • Financial Modelling Course
    • Excel PivotTable Course
    • Excel for Customer Service Professionals
    • Excel for Operations Management Course
    • Excel for Decision Making Under Uncertainty Course
    • Excel for Finance Course
    • Excel Analysis ToolPak Course
    • Multi-User Pricing
  • Resources
    • Free Downloads
    • Excel Functions Explained
    • Excel Formulas
    • Excel Add-ins
    • IF Function
      • Excel IF Statement Explained
      • Excel IF AND OR Functions
      • IF Formula Builder
    • Time & Dates in Excel
      • Excel Date & Time
      • Calculating Time in Excel
      • Excel Time Calculation Tricks
      • Excel Date and Time Formatting
    • Excel Keyboard Shortcuts
    • Excel Custom Number Format Guide
    • Pivot Tables Guide
    • VLOOKUP Guide
    • ALT Codes
    • Excel VBA & Macros
    • Excel User Forms
    • VBA String Functions
  • Members
    • Login
    • Password Reset
  • Blog
  • Excel Webinars
  • Excel Forum
    • Register as Forum Member

return a value of Function and use it in macro|VBA & Macros|Excel Forum|My Online Training Hub

You are here: Home / return a value of Function and use it in macro|VBA & Macros|Excel Forum|My Online Training Hub
Avatar
sp_LogInOut Log In sp_Registration Register
sp_Search Search
Advanced Search
Search
Forum Scope




Match



Forum Options



Minimum search word length is 3 characters - maximum search word length is 84 characters
sp_Search Search
sp_RankInfo
Lost password?
sp_CrumbsHome HomeExcel ForumVBA & Macrosreturn a value of Function and use …
sp_PrintTopic sp_TopicIcon
return a value of Function and use it in macro
Avatar
dorsa ss

New Member
Members
Level 0
Forum Posts: 1
Member Since:
April 3, 2019
sp_UserOfflineSmall Offline
1
April 3, 2019 - 6:46 am
sp_Permalink sp_Print

I write a macro that have a function for calculating the factorial of numbers.

and I want call it in my sub and return the value of that factorial function in a cell in my sheet. but when I run my macro it just return 0 to me.

this is my code:

 

Function Factorial(x As Integer) As Integer

Dim i As Integer

Dim F As Integer

F = 1

For i = 1 To x

Factorial = Factorial * i

Next i

End Function

******

Sub macro1()

Dim j, k As Integer

For j = 2 To 8

u = (10) ^ (-7 + j) Cells(j, 3).Value = u Cells(j, 6).FormulaR1C1 = _ "=-0.5772-LN(RC[-3])+RC[-3]-((RC[-3]^2)/(2*FACT(2)))+((RC[-3]^3)/(3*FACT(3)))-((RC[-3]^4)/(4*FACT(4)))"

Next j

Cells(8, 8) = Factorial(3)

End Sub

 

my function is work truely but when I want to call it return the 0.how can I solve my problem?

Avatar
Philip Treacy
Admin
Level 10
Forum Posts: 1518
Member Since:
October 5, 2010
sp_UserOfflineSmall Offline
2
April 3, 2019 - 11:39 am
sp_Permalink sp_Print

Hi Dorsa,

You start working out the factorial using an uninitialized variable 'Factorial' which has a default value of 0.  So your function result is always 0

Using basic debugging you could have discovered this easily 🙂

Read up on debugging with these articles

Debugging VBA

More Tips for Debugging VBA

 

Here's the working function

 

  Function Factorial(x As Integer) As Integer

    Dim i As Integer

    Dim F As Integer

    F = 1

    For i = 1 To x

      F = F * i

    Next i

    Factorial = F

  End Function

 

Regards

Phil

sp_Feed
Go to top
Forum Timezone: Australia/Brisbane
Most Users Ever Online: 245
Currently Online: Shanna Getschel, andria young, RAMEZ ATTAR
Guest(s) 10
Currently Browsing this Page:
1 Guest(s)
Top Posters:
SunnyKow: 1432
Anders Sehlstedt: 871
Purfleet: 412
Frans Visser: 346
David_Ng: 306
lea cohen: 219
Jessica Stewart: 205
A.Maurizio: 202
Aye Mu: 201
jaryszek: 183
Newest Members:
Bruce Tang Nian
Scot C
Othman AL MUTAIRI
Misael Gutierrez Sr.
Attif Ihsan
Kieran Fee
Murat Hasanoglu
Brett Dryland
Saeed Aldousari
Bhuwan Devkota
Forum Stats:
Groups: 3
Forums: 24
Topics: 6222
Posts: 27293

 

Member Stats:
Guest Posters: 49
Members: 31918
Moderators: 3
Admins: 4
Administrators: Mynda Treacy, Philip Treacy, Catalin Bombea, FT
Moderators: MOTH Support, Velouria, Riny van Eekelen
© Simple:Press —sp_Information

Sidebar

Blog Categories

  • Excel
  • Excel Charts
  • Excel Dashboard
  • Excel Formulas
  • Excel PivotTables
  • Excel Shortcuts
  • Excel VBA
  • General Tips
  • Online Training
  • Outlook
  • Power Apps
  • Power Automate
  • Power BI
  • Power Pivot
  • Power Query
microsoft mvp logo
trustpilot excellent rating
Secured by Sucuri Badge
MyOnlineTrainingHub on YouTube Mynda Treacy on Linked In Mynda Treacy on Instagram Mynda Treacy on Twitter Mynda Treacy on Pinterest MyOnlineTrainingHub on Facebook
 

Company

  • About My Online Training Hub
  • Disclosure Statement
  • Frequently Asked Questions
  • Guarantee
  • Privacy Policy
  • Terms & Conditions
  • Testimonials
  • Become an Affiliate

Support

  • Contact
  • Forum
  • Helpdesk - For Technical Issues

Copyright © 2023 · My Online Training Hub · All Rights Reserved. Microsoft and the Microsoft Office logo are trademarks or registered trademarks of Microsoft Corporation in the United States and/or other countries. Product names, logos, brands, and other trademarks featured or referred to within this website are the property of their respective trademark holders.