• Skip to main content
  • Skip to header right navigation
  • Skip to site footer

My Online Training Hub

Learn Dashboards, Excel, Power BI, Power Query, Power Pivot

  • Courses
  • Pricing
    • Free Courses
    • Power BI Course
    • Excel Power Query Course
    • Power Pivot and DAX Course
    • Excel Dashboard Course
    • Excel PivotTable Course – Quick Start
    • Advanced Excel Formulas Course
    • Excel Expert Advanced Excel Training
    • Excel Tables Course
    • Excel, Word, Outlook
    • Financial Modelling Course
    • Excel PivotTable Course
    • Excel for Customer Service Professionals
    • Excel for Operations Management Course
    • Excel for Decision Making Under Uncertainty Course
    • Excel for Finance Course
    • Excel Analysis ToolPak Course
    • Multi-User Pricing
  • Resources
    • Free Downloads
    • Excel Functions Explained
    • Excel Formulas
    • Excel Add-ins
    • IF Function
      • Excel IF Statement Explained
      • Excel IF AND OR Functions
      • IF Formula Builder
    • Time & Dates in Excel
      • Excel Date & Time
      • Calculating Time in Excel
      • Excel Time Calculation Tricks
      • Excel Date and Time Formatting
    • Excel Keyboard Shortcuts
    • Excel Custom Number Format Guide
    • Pivot Tables Guide
    • VLOOKUP Guide
    • ALT Codes
    • Excel VBA & Macros
    • Excel User Forms
    • VBA String Functions
  • Members
    • Login
    • Password Reset
  • Blog
  • Excel Webinars
  • Excel Forum
    • Register as Forum Member

Macro for File save base on today |VBA & Macros|Excel Forum|My Online Training Hub

You are here: Home / Macro for File save base on today |VBA & Macros|Excel Forum|My Online Training Hub
Avatar
sp_LogInOut Log In sp_Registration Register
sp_Search Search
Advanced Search|Last Search Results
Search
Forum Scope




Match



Forum Options



Minimum search word length is 3 characters - maximum search word length is 84 characters
sp_Search Search
sp_RankInfo
Lost password?
sp_CrumbsHome HomeExcel ForumVBA & MacrosMacro for File save base on today
sp_PrintTopic sp_TopicIcon
Macro for File save base on today
Avatar
David_Ng
Member
Members
Level 0
Forum Posts: 306
Member Since:
December 5, 2016
sp_UserOfflineSmall Offline
1
August 21, 2019 - 5:17 pm
sp_Permalink sp_Print

I tried follow vb script, but not work, can some one hlep to rectify

Sub File_Save()
ActiveSheet.Name = Format(Now, "dd-mmm-yyyy")
 Range("A1").Select
ActiveWorkbook.SaveAs Filename:="D:\AGE00OH2104\AMC\" & ActiveSheet.Name & ".xls", FileFormat:=xlNormal, Password:="", WriteResPassword:="", _
   ReadOnlyRecommended:=False, CreateBackup:=False
   Application.DisplayAlerts = Flase
   ActiveWorkbook.Close
     Range("A1").Select
End Sub

Avatar
David_Ng
Member
Members
Level 0
Forum Posts: 306
Member Since:
December 5, 2016
sp_UserOfflineSmall Offline
2
August 21, 2019 - 5:37 pm
sp_Permalink sp_Print

The macro work on a seprate Excel file but not in a macro workbook, which  contains some other Macros

Avatar
Philip Treacy
Admin
Level 10
Forum Posts: 1518
Member Since:
October 5, 2010
sp_UserOfflineSmall Offline
3
August 21, 2019 - 5:47 pm
sp_Permalink sp_Print

Hi David,

How exactly does it not work?  If you are getting an error you need to tell us what it is.

When I try this code it works fine, with some minor modifications, like removing the Select statements. 

I do have to change the save path from D:\AGE00OH2104\AMC\ to something that exists on my PC.  Does that folder/path exist on your PC?

Sub File_Save()

   ActiveSheet.Name = Format(Now, "dd-mmm-yyyy")

   ActiveWorkbook.SaveAs Filename:="D:\AGE00OH2104\AMC\" & ActiveSheet.Name & ".xls", FileFormat:=xlNormal

   ActiveWorkbook.Close

End Sub

Are you sure you want a .xls file? Because your saving a macro in the workbook.  I'm using Excel 2013, not sure what version you have.  Check the file formats

https://docs.microsoft.com/en-.....fileformat

Regards

Phil

Avatar
Philip Treacy
Admin
Level 10
Forum Posts: 1518
Member Since:
October 5, 2010
sp_UserOfflineSmall Offline
4
August 21, 2019 - 5:49 pm
sp_Permalink sp_Print

Hi David,

I've just seen your 2nd post.  Perhaps the issue is that the other workbook is a .xlsm file?

Again, without the exact error message it's difficult to give advice.

Phil

Avatar
David_Ng
Member
Members
Level 0
Forum Posts: 306
Member Since:
December 5, 2016
sp_UserOfflineSmall Offline
5
August 21, 2019 - 6:04 pm
sp_Permalink sp_Print

Thanks so much Philip!

Yes , agreed it works with a separate file but not work in a Macro workbook.

I capture the screen for reference but sorry they are in Chinese, basically it tells the property of the syntex is not well defined or something like the

parameter is not correctly set 

Avatar
David_Ng
Member
Members
Level 0
Forum Posts: 306
Member Since:
December 5, 2016
sp_UserOfflineSmall Offline
6
August 21, 2019 - 6:31 pm
sp_Permalink sp_Print

Philip, thanks again your effort

Then, how to write the Macro to auto save the file in xlsx  OR  xlsm format,

and at the same time the Work book structure and the Macro is protected.

sp_Feed
Go to top
Forum Timezone: Australia/Brisbane
Most Users Ever Online: 245
Currently Online: Brian Pham
Guest(s) 8
Currently Browsing this Page:
1 Guest(s)
Top Posters:
SunnyKow: 1432
Anders Sehlstedt: 871
Purfleet: 412
Frans Visser: 346
David_Ng: 306
lea cohen: 219
Jessica Stewart: 205
A.Maurizio: 202
Aye Mu: 201
jaryszek: 183
Newest Members:
stuart burge
Bruce Tang Nian
Scot C
Othman AL MUTAIRI
Misael Gutierrez Sr.
Attif Ihsan
Kieran Fee
Murat Hasanoglu
Brett Dryland
Saeed Aldousari
Forum Stats:
Groups: 3
Forums: 24
Topics: 6223
Posts: 27295

 

Member Stats:
Guest Posters: 49
Members: 31920
Moderators: 3
Admins: 4
Administrators: Mynda Treacy, Philip Treacy, Catalin Bombea, FT
Moderators: MOTH Support, Velouria, Riny van Eekelen
© Simple:Press —sp_Information

Sidebar

Blog Categories

  • Excel
  • Excel Charts
  • Excel Dashboard
  • Excel Formulas
  • Excel PivotTables
  • Excel Shortcuts
  • Excel VBA
  • General Tips
  • Online Training
  • Outlook
  • Power Apps
  • Power Automate
  • Power BI
  • Power Pivot
  • Power Query
microsoft mvp logo
trustpilot excellent rating
Secured by Sucuri Badge
MyOnlineTrainingHub on YouTube Mynda Treacy on Linked In Mynda Treacy on Instagram Mynda Treacy on Twitter Mynda Treacy on Pinterest MyOnlineTrainingHub on Facebook
 

Company

  • About My Online Training Hub
  • Disclosure Statement
  • Frequently Asked Questions
  • Guarantee
  • Privacy Policy
  • Terms & Conditions
  • Testimonials
  • Become an Affiliate

Support

  • Contact
  • Forum
  • Helpdesk - For Technical Issues

Copyright © 2023 · My Online Training Hub · All Rights Reserved. Microsoft and the Microsoft Office logo are trademarks or registered trademarks of Microsoft Corporation in the United States and/or other countries. Product names, logos, brands, and other trademarks featured or referred to within this website are the property of their respective trademark holders.